[SPARK-14482][SQL] Change default Parquet codec from gzip to snappy #12256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -136,14 +125,7 @@ private[sql] class DefaultSource | |||
| sqlContext.conf.writeLegacyParquetFormat.toString) | |||
|
|
|||
| // Sets compression scheme | |||
| conf.set( | |||
There was a problem hiding this comment.
the old nested map, getOrElse was super confusing...
@liancheng / @HyukjinKwon let's avoid doing things like this in the future
|
Test build #55333 has finished for PR 12256 at commit
|
|
cc @nongli |
|
LGTM |
|
Merging in master. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changes were proposed in this pull request?
Based on our tests, gzip decompression is very slow (< 100MB/s), making queries decompression bound. Snappy can decompress at ~ 500MB/s on a single core.
This patch changes the default compression codec for Parquet output from gzip to snappy, and also introduces a ParquetOptions class to be more consistent with other data sources (e.g. CSV, JSON).
How was this patch tested?
Should be covered by existing unit tests.